Remove employment income manual code #155
Conversation
|
Oh, the memories 😿 |
| expect_manual_title_to_be("This prototype of the Employment Income Manual is no longer available") | ||
| expect(page.status_code).to eq(200) | ||
| end | ||
|
|
||
| context "prototype HMRC manual has now been published for real" do |
There was a problem hiding this comment.
It probably makes sense to get rid of this test too, it doesn't make sense with the fallback code gone.
There was a problem hiding this comment.
Oh yeah! Deleted it. I forgot to read any further down the file...
tommyp
force-pushed
the
remove-employment-income-manual-code
branch
from
da087b1 to
da656b2
Compare
| base_path: "/guidance/employment-income-manual", | ||
| type: "prefix", | ||
| publishing_app: 'manuals-frontend', | ||
| rendering_app: 'manuals-frontend' |
There was a problem hiding this comment.
We should make sure that this route is properly withdrawn too.
|
The view for the manual won't be used any more, so we should remove that too. |
tommyp
force-pushed
the
remove-employment-income-manual-code
branch
from
da656b2 to
fd18f3a
Compare
|
I've made use of the new |
This manual was used as a placeholder to demonstrate Manuals Frontend before we had any content. The placeholder is no longer being used so this commit removes the `before_filter`, the tests, the views and changes the rake task which publishes the route for one which publishes a gone route.
tommyp
force-pushed
the
remove-employment-income-manual-code
branch
from
fd18f3a to
7e078d1
Compare
|
I've updated this PR to publish a gone content item to the Publishing API. This code can be removed after this is merged and deployed. |
…-code Remove employment income manual code
This manual was used as a placeholder to demonstrate Manuals Frontend
before we had any content. The placeholder is no longer being used so
this commit removes the
before_filter, the tests and a rake task whichpublishes a route for the manual.