Fix text contrast of disabled checkboxes
#5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have noticed that when checkboxes have the `disabled` attribute set[1], the text does not meet WCAG standards[2] for colour contrast. This is true for the label[3], and worse for the hint text[4]. This is caused by some CSS in GOV.UK Frontend[5]. I propose: - using the secondary text colour for - the checkbox itself (which is inherited through `currentColor`) - the label text - the hint text - using a light grey fill to give an additional visual cue that the choice can’t be filled in by clicking it *** This is the same thing we did for radio buttons in https://github.com/alphagov/notifications-admin/pull/4744/files *** 1. Using `disabled` is not often the best way to do things (and is not documented in the Design System) but sometimes it’s appropriate 2. WCAG 2.0 AA requires a contrast ratio of 4.5:1 for ‘normal text’ 3. `$govuk-text-colour` with `opacity: .5` applied computes to a value of `#858585`, which gives a contrast ratio of 3.69:1 against a white background 4. `$govuk-secondary-text-colour` with `opacity: .5` applied computes to a value of `#a8acae`, which gives a contrast ratio of 2.28:1 against a white background 5. https://github.com/alphagov/govuk-frontend/blob/6271937e80f6147b7f3f1a248c47eb6d9f5a7061/packages/govuk-frontend/src/govuk/components/checkboxes/_index.scss#L138 6. Colour alone isn’t used here to differentiate – there is the semantics of the `disabled` attribute itself, the different cursor behaviour, and the content of the hint text
kr8n3r
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that when checkboxes have the
disabledattribute set1, the text does not meet WCAG standards2 for colour contrast. This is true for the label3, and worse for the hint text4.This is caused by some CSS in GOV.UK Frontend5.
I propose:
currentColor)This is the same thing we did for radio buttons in #4744
Before
After
disabledis not often the best way to do things (and is not documented in the Design System) but sometimes it’s appropriate$govuk-text-colourwithopacity: .5applied computes to a value of#858585, which gives a contrast ratio of 3.69:1 against a white background$govuk-secondary-text-colourwithopacity: .5applied computes to a value of#a8acae, which gives a contrast ratio of 2.28:1 against a white backgrounddisabledattribute itself, the different cursor behaviour, and the content of the hint text