-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding prototype #5328
Draft
klssmith
wants to merge
24
commits into
main
Choose a base branch
from
onboarding-prototype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Onboarding prototype #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klssmith
force-pushed
the
onboarding-prototype
branch
from
December 18, 2024 16:02
5f96f53
to
c772d6d
Compare
klssmith
force-pushed
the
onboarding-prototype
branch
3 times, most recently
from
January 3, 2025 14:46
c854282
to
fd062ba
Compare
klssmith
force-pushed
the
onboarding-prototype
branch
from
January 6, 2025 13:09
fd062ba
to
759e277
Compare
This adds the notification banner from the design system when a user has logged in for the first time after creating a service. Still to do: - Work out if invited users see the banner too
This is highlighted for pages which can only be reached via the go-live checklist.
Still to do: - Once this is linked to from more pages the back link will need to go to the page you came from
Uses the GOV.UK Frontend task list styling and updates the content on the request to go live page. This updates the description of the tasks shown to have the new content. Still to do: - Add the new tasks that will now appear in the list
Still to do: - We need to actually record if the service is unique or not when the form is submitted.
Stored in Redis since this is a prototype, and not as a new column on the services table.
This checks whether a user has visited the page to add an email sender and clicked "Save" even if they decided not to add one and to go with the default of the service name. The result of this is stored in Redis since this is a prototype.
Use checkboxes with conditional content to display input fields. Field validation remains as it was. If fields have value or if they contain the error we check the checkbox so that the field is display and error visible (if applicable) Prototype code as checkboxes are in the view and we don't validate if the submit without checking any.
This new page prompts someone who has no email reply-to addresses to set one up when sending an email template. We only showed the "Where should replies come back to?" page before if you had multiple reply-to addresses. This new version of the page is shown if you have none, but only to people with the manage settings permission, since others won't be able to make the change.
The page to select an email sender name now gets shown after a user adds their first email template if they haven't already confirmed which email sender name they want to use. The back links on this page go to either the settings page or the templates page, depending on how you got to the page.
Changes the header colour to the blue we use in production to avoid confusion for any participants who already use Notify.
This previously always went to the service settings page, but now goes back to the ready to go live page if that's where you came from.
If you get to the page to add a reply-to address from the go-live checklist, the back link on this page takes you back to the go-live checklist (instead of the default of the settings page). After you have added a reply-to address from the go-live checklist we now redirect you back to the go-live checklist (instead of the page to show all email reply-to addreses). If you are on the page where the email address is still being verified and click "back" twice you will be taken out of the go-live route, but this is an edge case and fine for the prototype.
If you get to the page to add a reply-to address from the route of sending an email, the back link takes you back to the page to set the sender. After you have added a reply-to address as part of the route of sending an email, you get taken to the page to send the email (if you've just added the first address) or to the page to set the sender (if you have multiple senders).
The links were going to the right place ('.service_add_email_reply_to'), but if we want to go back multiple times then the query parameters need to be passed through.
klssmith
force-pushed
the
onboarding-prototype
branch
from
January 7, 2025 13:58
759e277
to
2d73873
Compare
klssmith
force-pushed
the
onboarding-prototype
branch
from
January 7, 2025 14:20
2d73873
to
032ac3e
Compare
This is purely to help when running user research sessions, and not a change we want to make in other environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opened as a PR so that it can be deployed to a dev environment, but is not intended to be merged or treated as production code.