Add a try/except around the code to get the files. #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to log the exception but keep going. That way the "good" files still get sent and we can investigate why a file failed.
idavidmcdonald
approved these changes
Mar 19, 2020
| call(current_app.config['LETTERS_PDF_BUCKET_NAME'], '2020-02-17/NOTIFY.REF1.D.2.C.C.20200217150000.PDF'), | ||
| call(current_app.config['LETTERS_PDF_BUCKET_NAME'], '2020-02-17/NOTIFY.REF0.D.2.C.C.20200217160000.PDF'), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Would be nice to also assert our log message for the error case but we can let that slide for the moment given time
leohemsted
added a commit
that referenced
this pull request
Mar 16, 2023
otherwise we'll just do nothing until the next day, when we'll try and send it again. i think the chance of it appearing in s3 overnight feels slim to unlikely - this was behaviour we added three years ago[^1] but i'm not sure i remember us ever receiving these log messages. [^1]: #2760
leohemsted
added a commit
that referenced
this pull request
Mar 16, 2023
otherwise we'll just do nothing until the next day, when we'll try and send it again. i think the chance of it appearing in s3 overnight feels slim to unlikely - this was behaviour we added three years ago[^1] but i'm not sure i remember us ever receiving these log messages. [^1]: #2760
leohemsted
added a commit
that referenced
this pull request
Mar 16, 2023
otherwise we'll just do nothing until the next day, when we'll try and send it again. i think the chance of it appearing in s3 overnight feels slim to unlikely - this was behaviour we added three years ago[^1] but the log message never fired due to a bug in how the function was called. it feels safer and more correct to set the letter to technical-failure. we'll get a proper exception log and it'll be easier to distinguish failed letters in technical-failure that we need to action from new letters in created that will go out as normal [^1]: #2760
leohemsted
added a commit
that referenced
this pull request
Mar 17, 2023
otherwise we'll just do nothing until the next day, when we'll try and send it again. i think the chance of it appearing in s3 overnight feels slim to unlikely - this was behaviour we added three years ago[^1] but the log message never fired due to a bug in how the function was called. it feels safer and more correct to set the letter to technical-failure. we'll get a proper exception log and it'll be easier to distinguish failed letters in technical-failure that we need to action from new letters in created that will go out as normal [^1]: #2760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to log the exception but keep going. That way the "good" files still get sent and we can investigate why a file failed.