Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#115858399] Document steps to set up a ci, staging or prod environment #166

Merged
merged 4 commits into from
Mar 18, 2016

Conversation

alext
Copy link
Contributor

@alext alext commented Mar 18, 2016

What

There are a few differences when deploying to non-dev accounts. This
pulls these details out into a separate document.

How to review

Check that the new docs are clear, and cover the necessary details.

Who can review

Anyone but myself.

alext added 4 commits March 18, 2016 10:21
This it no longer quite correct since #145 (Use correct fly versions)
which refactored how environment variables are setup.
There are a few differences when deploying to non-dev accounts. This
pulls these details out into a separate document.
By setting CONCOURSE_ATC_PASSWORD
@jimconner
Copy link
Contributor

LGTM... but not merging just yet to give others time to review.

@keymon keymon self-assigned this Mar 18, 2016

If not, it can be found in the `basic_auth_password` property of `concourse-manifest.yml` in the state bucket.
If necessary, the concourse password can be found in the `basic_auth_password`
property of `concourse-manifest.yml` in the state bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we provide a script like:

TMPFILE=$(mktemp); aws s3 cp s3://hector-state/concourse-manifest.yml $TMPFILE --region eu-west-1 && ./concourse/scripts/val_from_yaml.rb  jobs.0.properties.atc.basic_auth_password $TMPFILE; rm $TMPFILE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws s3 cp can write to STDOUT and val_from_yaml.rb can read from STDIN, so we could avoid using a temporary file at all. Probably one for the Makefile though, related to this story: https://www.pivotaltracker.com/story/show/113160603

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a final fallback for finding out this password, we decided to leave this scripting out for the moment. Typically you'd either be using the password from the credentials store, or generating it from a key+deploy_env

@keymon
Copy link
Contributor

keymon commented Mar 18, 2016

LGTM, I would merge.

keymon added a commit that referenced this pull request Mar 18, 2016
[#115858399] Document steps to set up a ci, staging or prod environment
@keymon keymon merged commit c186709 into master Mar 18, 2016
@keymon keymon deleted the deployment_docs branch March 18, 2016 12:57
richardTowers added a commit that referenced this pull request Apr 26, 2019
Full diff: alphagov/paas-admin@v0.82.0...v0.94.0

Contains the following PRs by human beings:

- #146 Stub APIs needed for the calculator
- #148 Request logging
- #160 Use javascript naming for request log interceptor
- #173 Support: Fix bug showing allocations
- #180 Skip calculator getQuote if there are no items
- #181 Remove low-value, flakey test

And the following dependabot specials:

- #161 Bump nunjucks from 3.1.3 to 3.2.0
- #165 Bump glob from 7.1.2 to 7.1.3
- #164 Bump @types/source-map-support from 0.4.1 to 0.5.0
- #162 Bump webpack-cli from 3.1.0 to 3.3.1
- #170 Bump pino from 5.1.0 to 5.12.3
- #169 Bump @types/jest from 23.3.1 to 24.0.11
- #168 Bump nodemon-webpack-plugin from 4.0.3 to 4.0.8
- #167 Bump express-static-gzip from 1.1.1 to 1.1.3
- #166 Bump @types/uuid from 3.4.3 to 3.4.4
- #163 Bump @types/helmet from 0.0.38 to 0.0.43
- #174 Bump tslint-microsoft-contrib from 5.2.0 to 6.1.1
- #175 Bump qs from 6.5.2 to 6.7.0
- #176 Bump moment from 2.22.2 to 2.24.0
- #177 Bump jest from 23.5.0 to 23.6.0
- #178 Bump @types/passport from 0.4.6 to 1.0.0
- #179 Bump jest and ts-jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants