[Support] Update VPC peering terraform #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new vpc peering entry results in terraform recreating existing connections because it uses the count parameter. This updates the resources to use the for_each parameter so this doesn't happen.
|
I'm deploying this to my dev env to review it 🎉 |
46bit
approved these changes
Nov 19, 2020
|
Unfortunately this triggered an AWS Terraform Provider bug and we had to revert in #2521. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a new vpc peering entry results in terraform recreating existing
connections because it uses the count parameter. This updates the resources
to use the for_each parameter so this doesn't happen.
How to review
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨