load balancers: push logs to centralized bucket & update logit filters #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcgds
approved these changes
Aug 25, 2023
|
This needs modification to work with the multi-region shenanigans... |
risicle
force-pushed
the
ris-centralise_alb_logs
branch
from
1edb5f0
to
e0d267e
Compare
Hopefully this gets rid of the cruft that the cloudfoundry pipelines add.
risicle
force-pushed
the
ris-centralise_alb_logs
branch
from
3979c40
to
8d55654
Compare
|
Ok good now, though think it might need a re-review. |
AP-Hunt
reviewed
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://www.pivotaltracker.com/story/show/185739015
This is @whi-tw 's work, barely modified. Looks sensible and seems to work for me in a dev env.
Logs go into a per-account bucket because we have per-account logit stacks. As such this depends on https://github.com/alphagov/paas-aws-account-wide-terraform/pull/375 having been run in your aws account.
How to review
👀 , look at dev03? Deploy to your own env?
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨