Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions instead of Heroku #462

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Use GitHub Actions instead of Heroku #462

merged 1 commit into from
Oct 12, 2023

Conversation

MuriloDalRi
Copy link
Contributor

@MuriloDalRi MuriloDalRi marked this pull request as draft October 12, 2023 10:24
@MuriloDalRi MuriloDalRi force-pushed the gha branch 5 times, most recently from 154249a to b7637aa Compare October 12, 2023 13:26
@MuriloDalRi MuriloDalRi marked this pull request as ready for review October 12, 2023 13:26
@MuriloDalRi MuriloDalRi marked this pull request as draft October 12, 2023 15:54
@MuriloDalRi MuriloDalRi force-pushed the gha branch 2 times, most recently from bb8eccb to 3a8644a Compare October 12, 2023 16:14
@MuriloDalRi MuriloDalRi marked this pull request as ready for review October 12, 2023 16:15
@MuriloDalRi MuriloDalRi enabled auto-merge October 12, 2023 16:17
robinjam
robinjam approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@robinjam robinjam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 👍

Could also remove thin and sinatra from the Gemfile now, right?

@MuriloDalRi MuriloDalRi merged commit 85269cd into main Oct 12, 2023
3 checks passed
@MuriloDalRi MuriloDalRi deleted the gha branch October 12, 2023 16:23
@MuriloDalRi
Copy link
Contributor Author

Nice, LGTM! 👍

Could also remove thin and sinatra from the Gemfile now, right?

Yes, just thought about that. I'll raise a PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjam robinjam robinjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuriloDalRi @robinjam