Add support for layout header component in static #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During development the account nav markup was copied over from the layout header component instead of using the component itself. This was probably due to time constraints. The component audits are complaining that we are including the assets for layout_header, when we are not using the component. To fix this problem, we are removing the hard coded account navigation from static, and using the layout header component in its place. That would technically be duplicating the header, so these changes are here to ensure that the layout header is conditionally revealed only when the account is enabled and the account nav should be present.
danacotoran
force-pushed
the
account-nav-layout-header
branch
from
d537271 to
954fe61
Compare
barrucadu
reviewed
Feb 15, 2021
|
Thanks for checking this @barrucadu. |
barrucadu
approved these changes
Feb 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development the markup for the account nav (appears on the transition page, and transition checker) was copied over from the layout header component instead of using the component itself. This was probably due to time constraints.
The component audits are complaining that we are including the assets for
layout_headerin static, when we are not using the component.To fix this problem, we are removing the hard coded account navigation from static, and using the layout header component in its place: alphagov/static#2408
That is technically duplicating the header – these changes are here to conditionally swap the
#global-headerfor thelayout_headeronly when the account is enabled and the account nav should be present.https://trello.com/c/9Kjy1hjb