Add custom result page for start a business #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
changed the title
alex-ju
force-pushed
the
add-custom-result-page
branch
from
b928fbb to
a79f258
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
a79f258 to
ce095c3
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
ce095c3 to
4101f38
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
4101f38 to
c6f1218
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
c6f1218 to
a8d0511
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
a8d0511 to
dfabb53
Compare
alex-ju
force-pushed
the
add-custom-result-page
branch
from
dfabb53 to
9feec55
Compare
theseanything
requested changes
Mar 31, 2021
lib/smart_answer_flows/next-steps-for-your-business/outcomes/results.erb
Show resolved
Hide resolved
alex-ju
force-pushed
the
add-custom-result-page
branch
from
9feec55 to
f33e643
Compare
theseanything
approved these changes
Apr 6, 2021
Update the layout to be able to render a full-width hero element between the header and the main content of the page. This requires removing the #wrapper container styles – we achieve that by swapping the slimmer template to header_footer_only.
Create a custom result page to be used in the next-steps-for-your-business flow.
Not using these extra paragraph tags also means the index page will look exactly the same after we switched to `header_footer_only` template.
alex-ju
force-pushed
the
add-custom-result-page
branch
from
f33e643 to
e272ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Build a custom template to render the results page for next steps for your business flow with a default set of items.
This includes adding a hero section, a result item and a result section component.
Why
To be able to show the results in a similar way with the version tested with users.
Visual changes
Trello card