-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Spike - Using the public layout components in Static #2127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
public-layout-repeat
branch
from
July 9, 2020 12:56
e5dbad1
to
43145d5
Compare
Add and call a stylesheet for emergency banners (needs fixing)
Can we close this pull request? I think it's covered by #2411. |
Closing, superseded elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is the (ongoing) outcome of spiking implementing the public layout components from the govuk_publishing_components gem. This work was done as part of the drive to reduce legacy and adopt more of the design system across gov.uk to make the site comply better with accessibility standards and to ease the use of the design system and components. This was done by the Frontend and Accessibility mission team which, as of April 2020, is now paused.
The step by step of the work done is documented here:
https://docs.google.com/document/d/1GbuOlFpLxDNFbcC8QbnLdyZBxwu_Bfl5qGcAAXxqCr0/edit#
and it is covered under this ticket:
https://trello.com/c/uEIU7R4m/238-switch-layout-template-for-public-template-in-static
This branch is not intended for merge, but is meant to be a disposable example of an attempt at implementation. At this point tests are failing and haven't been addressed.
The google document linked has more detail but as a TLDR this branch:
More work is needed, again outlined in the linked document, mostly around: