Remove custom apple touch icons and redirects in static #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
remove-apple-touch-icon-redirects
branch
from
fdefa7b
to
f437fe9
Compare
MartinJJones
changed the title
The custom apple touch icons are not required in static as we use the apple-touch-icon provided by govuk-frontend (Design System) across GOV.UK via the link tag in layout_for_public.html.erb from the govuk_publishing_components gem
The IconRedirectController will now only redirect the favicon.ico file provided by govuk-frontend (Design System) All references to `apple-touch-icons` have been removed as this approach is not required. The apple-touch-icon is provided by govuk-frontend (Design System) across GOV.UK via the link tag in layout_for_public.html.erb from the govuk_publishing_components gem.
The test will now only check that the favicon.ico file is redirected. Uncommented a test that was previously broken when checking for apple touch icons. It appears that in order for the tests to pass, there needs to be an entry in both routes.rb and publishing_api.rake, for example favicon.ico and apple-touch-icon.png pass (referenced in both files), but apple-touch-icon-152x152 does not (only referenced in routes.rb)
MartinJJones
force-pushed
the
remove-apple-touch-icon-redirects
branch
from
f437fe9
to
f37d969
Compare
KludgeKML
approved these changes
Sep 18, 2024
hannako
approved these changes
Sep 19, 2024
hannako
added a commit
that referenced
this pull request
Sep 19, 2024
hannako
force-pushed
the
remove-apple-touch-icon-redirects
branch
from
29ec945
to
f37d969
Compare
hannako
added a commit
that referenced
this pull request
Sep 19, 2024
hannako
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
apple-touch-icon.png(120x120px)apple-touch-icon-152x152.pngapple-touch-icon-167x167.pngapple-touch-icon-180x180.pngpublishing_api.rakefavicon.icoroutes.rbandpublishing_api.rake, for examplefavicon.icoandapple-touch-icon.pngpass (referenced in both files),apple-touch-icon-152x152does not pass (only referenced in routes.rb)Trello card
Why
linktag in layout_for_public.html.erbFurther info
The apple touch icon is primarily used on the iOS/iPadOS home screen.
I tested this change on Staging on older iOS devices to check the apple-touch-icon still works as expected when adding the GOV.UK website to the home screen, screenshots below.
iPhone 7 - iOS 10.3
iPhone 8 - iOS 11.4