Upgrade jQuery to 1.11.3 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests begun to fail with jQuery 1.11.3 The existing `beforeEach` and `afterEach` weren’t adequately cleaning up their HTML once a test was run. This led to multiple containers, which led to the newer jQuery picking the first empty one, rather than a later one containing the element we’re looking for. * Declare a new $block at the beginning of each template * Remove the $block at the end * Simplify click handling on elements
This was referenced Jul 27, 2015
|
Third party javascript should go in vendor/assets/javascripts/ - could we move it? |
|
Spoke to @jamiecobbett about moving jquery to the |
|
Talked to @fofr about the change a couple of days ago and was happy. This has been running on for a day, with no uptick in reported JS errors, so we're feeling confident rolling this out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/BMpUGtKT/62-upgrade-jquery-on-gov-uk
Update jQuery to 1.11.X to pickup 3 years worth of bug fixes new APIs and features (eg better CSS3 support, smaller, faster)
Major releases
Breaking changes resolved in previous PRs:
$.liveto$.onattr()withprop()where appropriate$.browserfor the plugins we use that still need it (jquery.history.jsused by tabs,jquery.player.js– Accessible Media Player)Prep for this upgrade
(When deploying this change we should keep an eye on the real time JavaScript errors in Google Analytics)