Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referenced opengraph image does not exist #194

Open
36degrees opened this issue Sep 8, 2020 · 0 comments
Open

Referenced opengraph image does not exist #194

36degrees opened this issue Sep 8, 2020 · 0 comments

Comments

@36degrees
Copy link
Contributor

The meta tags helper hardcodes an opengraph image at /images/govuk-large.png:

tech-docs-gem/lib/govuk_tech_docs/meta_tags.rb

Lines 50 to 52 in 210d3d4

def page_image
"#{host}/images/govuk-large.png"
end

This image does not exist in tech-docs-gem or tech-docs-template, and so 404s in most (all?) documentation projects.

The opengraph image is linked from GOV.UK Frontend, but is found at /assets/govuk/assets/images/govuk-opengraph-image.png.
@colinrotherham colinrotherham mentioned this issue Jul 28, 2023
Merged
colinrotherham added a commit to alphagov/govuk-frontend-docs that referenced this issue Aug 1, 2023
@colinrotherham
Fix link checker reporting
3e3adb6 
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
colinrotherham added a commit to alphagov/govuk-frontend-docs that referenced this issue Aug 3, 2023
@colinrotherham
Fix link checker reporting
ab8861d 
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
36degrees pushed a commit to alphagov/govuk-frontend-docs that referenced this issue Aug 7, 2023
@colinrotherham @36degrees
Fix link checker reporting
479151b 
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
36degrees pushed a commit to alphagov/govuk-frontend-docs that referenced this issue Aug 16, 2023
@colinrotherham @36degrees
Fix link checker reporting
78422fc 
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
@36degrees 36degrees mentioned this issue Aug 16, 2023
Merged
kr8n3r added a commit that referenced this issue Sep 18, 2024
@kr8n3r
Fix opengraph image path
031bab7 
Fixes #194
kr8n3r added a commit that referenced this issue Sep 18, 2024
@kr8n3r
Fix opengraph image path
1f6fb9f 
Fixes #194
kr8n3r added a commit that referenced this issue Sep 18, 2024
@kr8n3r
Fix opengraph image path
5521efc 
Fixes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@36degrees