Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on ffi issue to README #255

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Conversation

tombye
Copy link
Contributor

@tombye tombye commented Jul 30, 2021

Users of apps consuming this gem and running on OSX Mohave (10.14) can experience an issue with the ffi gem.

This adds a note to the README listing fixes for the issue.

See #254 for related discussion.

I can see the warning about bumping the gem version but, looking at the history, this seems to be done as a separate PR, following those with code changes in.

⚠️ Don't forget to update the gem version in the CHANGELOG before merging! When you're ready to release bump version file and generate a tag. ⚠️

Users of apps consuming this gem and running on OSX Mohave (10.14) can experience an issue with the ffi gem.

This adds a note to the README listing fixes for the issue.

See #254 for related discussion.
@tombye tombye marked this pull request as ready for review July 30, 2021 13:49
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tombye tombye requested a review from jonathanglassman July 30, 2021 15:13
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanglassman jonathanglassman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comments. Happy to discuss.

@tombye tombye merged commit 22bb649 into master Jul 30, 2021
@tombye tombye deleted the add-note-on-ffi-issue-to-readme branch July 30, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants