Drop support for end-of-life Ruby versions + update dependencies. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With middleman-sprockets 4.1, tests fail with: ``` /Users/sengi/src/alphagov/tech-docs-gem/vendor/bundle/ruby/3.3.0/gems/middleman-sprockets-4.1.1/lib/middleman-sprockets/resource.rb:37:in `block in sprockets_asset': ../../lib/source/stylesheets/manifest.css (Sprockets::FileNotFound) ```
These default gems are slated for removal from Ruby 3.4, but upstream gems that depend on them haven't updated their gemspecs yet (or hadn't at the time of release of the we're stuck on for now, at least). This somewhat helps forward-compatibility with Ruby 3.4.
|
I've removed the requirement for tests on ruby 2.7 will try to do a review in the next day or two (probably by just including the gem in another thing and making sure it works) |
heathd
approved these changes
May 9, 2024
|
I have tested against a local tech docs site using ruby 3.2.3. Everything seems to function correctly. |
|
Thanks @heathd! |
This was referenced May 15, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm audit fix).Someone with repo admin (or alphagov org admin) will need to update the repo's branch protection rules to fix the list of required checks.