Comment out GovukContentSecurityPolicy #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves this app having both a csp and content_security_policy.rb file. We choose the latter one as it is a Rails default that will get automatically added on Rails upgrades.
davidgisbey
approved these changes
Jan 25, 2023
davidgisbey
reviewed
Jan 25, 2023
`
Outdated
| # | ||
| # For more info on the GOV.UK CSP see: https://docs.publishing.service.gov.uk/manual/content-security-policy.html | ||
| # | ||
| # GovukContentSecurityPolicy.configure |
There was a problem hiding this comment.
Is this meant to be here?
There was a problem hiding this comment.
Do you mean the commented out code? It's intended to remain yes as that's how the CSP is configured.
There was a problem hiding this comment.
As in it's a new file called `
Looks like it might be a dupe
There was a problem hiding this comment.
Ha! Oh no 🤦 thank you for spotting that.
There was a problem hiding this comment.
No worries the rest of it looks good 👍
There was a problem hiding this comment.
Super, it's gone now. No idea how I even achieved that. Very pleased you caught it 😅
GOV.UK hadn't intended for this app to have the GOV.UK Content Security Policy yet, with us first planning to roll out this to frontend app. It looks like this was added as part of an outsourced Rails update [1], where the dev couldn't have known about our nuanced context. As this is an app that doesn't receive a lot of developer attention I'm disabling this as I don't want breaking changes to the CSP [2] to end up in this app. [1]: #919 [2]: alphagov/govuk_app_config#279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/lxxx5XLZ/178-govuk-has-a-half-implemented-content-security-policy-csp
GOV.UK hadn't intended for this app to have the GOV.UK Content Security
Policy yet, with us first planning to roll out this to frontend app. It
looks like this was added as part of an outsourced Rails update 1,
where the dev couldn't have known about our nuanced context.
As this is an app that doesn't receive a lot of developer attention I'm
disabling this as I don't want breaking changes to the CSP 2 to end up
in this app.