Merge pull request #9703 from alphagov/heros-without-content

Support hero blocks without content
alphagov · Dec 4, 2024 · b2b10ec · b2b10ec
2 parents aa313b1 + 916b7a2
commit b2b10ec
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/app/models/landing_page/block_factory.rb b/app/models/landing_page/block_factory.rb
@@ -13,6 +13,8 @@ def self.build(block, images)
       LandingPage::FeaturedBlock.new(block, images, blocks)
     in { type: "hero", hero_content: { blocks: } }
       LandingPage::HeroBlock.new(block, images, blocks)
+    in { type: "hero" }
+      LandingPage::HeroBlock.new(block, images, nil)
     in { type: "image" }
       LandingPage::ImageBlock.new(block, images)
     in { type: String, blocks: Array }

diff --git a/test/unit/app/models/landing_page/block_factory_test.rb b/test/unit/app/models/landing_page/block_factory_test.rb
@@ -7,6 +7,27 @@ class BlockFactoryTest < ActiveSupport::TestCase
     assert_instance_of LandingPage::BaseBlock, block
   end
 
+  test "#build builds hero blocks with content" do
+    images = []
+    config = {
+      "type" => "hero",
+      "image" => {},
+      "hero_content" => { "blocks" => [{ "type" => "some-type" }] },
+    }
+    block = LandingPage::BlockFactory.build(config, images)
+    assert_instance_of LandingPage::HeroBlock, block
+  end
+
+  test "#build builds hero blocks without content" do
+    images = []
+    config = {
+      "type" => "hero",
+      "image" => {},
+    }
+    block = LandingPage::BlockFactory.build(config, images)
+    assert_instance_of LandingPage::HeroBlock, block
+  end
+
   test "#build_all builds blocks" do
     images = []
     blocks = LandingPage::BlockFactory.build_all([{ "type" => "some-type" }, { "type" => "some-type" }], images)