Surface fixes for link validation errors #10024
Draft
+78
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngocd
force-pushed
the
surface-link-check-error
branch
3 times, most recently
from
455c08f to
c63bea4
Compare
lauraghiorghisor-tw
approved these changes
Mar 6, 2025
|
Hmmmm good point. Adding some screen shots. It currently looks like so, which isn't very readable: 
Making them an array / bullet point is slightly better but stlil have loads of room for improvement. We need some content / frontend guidance here 
|
|
Awaiting Content Guidance |
Currently fixes for any link validation errors that prevents publishing and scheduling are silent. The user only sees a high level message that there was something wrong with the links and not how to go about fixing it. If we surface the fixes we may receive less support tasks to manage.
… points Returning the fixes as a separate array item to be rendered as bullet points for readability in the sidebar
To mirror what is happening with Edition Publisher. Edition Publisher is publishing the errors as bullet points, whereas the Edition Scheduler is only returning one error message. With the introduction of fixes required for link validation, bullet points might help with readibility
minhngocd
force-pushed
the
surface-link-check-error
branch
from
c63bea4 to
c1bd845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fixes for any link validation errors that prevents publishing and scheduling are silent. The user only sees a high level message that there was something wrong with the links and not how to go about fixing it. If we surface the fixes we may receive less support tasks to manage.
https://trello.com/c/zuRPc1sS/3504-unable-to-publish-whitehall-drafts-unclear-broken-links-state
The fixes are rendered as bullet points when surfaced to the user, and the URL seems a bit too long for the sidebar..
Follow these steps if you are doing a Rails upgrade.