Add translations and sync the locales #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports translations directory from the outsourced key set provided by ASP.
Now we've imported translations, this test fails as its expecting a key to be blank, which is now present. Adds a stub to replicate the behaviour of a blank key.
The space should've been before the colon, rather than after.
I believe this code was originally added to prevent documents for certain languages (Arabic, Yiddish etc) assigning the documents slug the same text as the title. Using text from these languages in the URL can cause encoding errors. The intention was to use the document id, instead of the title, for the slug, if the `latin_script?` tag was false. However, this code is never actually used and I don't think the issue is still present. I've tested the behaviour in Arabic for a World News Article, and it successfully publishes with the document id as the slug.
This was mistakenly capitalized
Adds keys `i18n-task remove-unused` will ignore, as they're generated automatically.
`i18n-tasks remove-unused`
`bundle exec rake translation:add_missing`
1pretz1
force-pushed
the
add-translations
branch
from
d37f3fd
to
bd1dcd3
Compare
MuriloDalRi
reviewed
Nov 23, 2021
|
Thanks for the review @MuriloDalRi!
It's not strictly necessary to remove unused keys as part of the import, but I thought it would be useful to remove them, rather than add keys that are not actually used in the application. If we were to add them then this would create more work for us when we come to validate the locales. It is sad that the locale files have changed since we sent the files off and quite a few of them are no longer needed. |
MuriloDalRi
approved these changes
Nov 23, 2021
1pretz1
added a commit
that referenced
this pull request
Nov 25, 2021
This was incorrectly changed when importing locales: #6369
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports translations from the supplier (ASP). As part of this work, the translations have also been audited and synced.
More info in the commits ->
Trello:
https://trello.com/c/Xz78vNR4/2757-import-newly-sourced-translations-into-locale-files-5