Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all Sentry gems to 5.4.1 #6735

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Bump all Sentry gems to 5.4.1 #6735

merged 1 commit into from
Aug 15, 2022

Conversation

ollietreend
Copy link
Contributor

This commit bumps all three Sentry gems used by this project to version 5.4.1.

An internal API change was made in the Sentry gems which means 5.3.x gems aren't compatible with 5.4.x gems.

If all three gems aren't updated at the same time, we end up with test failures containing error messages like this:

exception expected, not
Class: <ArgumentError>
Message: <"wrong number of arguments (given 1, expected 2)">

For further details, see getsentry/sentry-ruby#1859 and getsentry/sentry-ruby#1865.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This commit bumps all three Sentry gems used by this project to version 5.4.1.

An internal API change was made in the Sentry gems which means 5.3.x gems aren't compatible with 5.4.x gems.

If all three gems aren't updated at the same time, we end up with test failures containing error messages like this:

```
exception expected, not
Class: <ArgumentError>
Message: <"wrong number of arguments (given 1, expected 2)">
```

For further details, see getsentry/sentry-ruby#1859 and getsentry/sentry-ruby#1865.
Copy link
Contributor

@beccapearce beccapearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@ollietreend ollietreend merged commit 4dafc39 into main Aug 15, 2022
@ollietreend ollietreend deleted the bump-sentry-to-5.4.1 branch August 15, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants