Add GitHub Action workflow for verifying pact tests #7094
Conversation
This moves the pact verification to a GitHub Action and will no longer be performed by a Jenkins build. This workflow will also be called by GDS API Adapters as part of it's CI build to assert that newly generated pacts are valid against this app. To avoid running this same task twice `pact:verify` is no longer part of the Jenkins test actions and instead the other rake default steps are included. For more details see alphagov/gds-api-adapters#1175
| @@ -15,7 +15,7 @@ node { | |||
| echo "Running a subset of the tests to check the content schema changes" | |||
| govuk.runRakeTask("test:publishing_schemas --trace") | |||
| } else { | |||
| sh("bundle exec rake") | |||
| sh("bundle exec rake lint test cucumber jasmine") | |||
There was a problem hiding this comment.
Hmmm I understand why you haven't just removed pact:verify from the default task (devs should be able to run the full test suite locally), but I think it would be cleaner to define a new Rake task that encapsulates the above, e.g.
task ci: %i[lint test cucumber jasmine] # Pact tests run separately on GitHub ActionsAnd then changing this to:
| sh("bundle exec rake lint test cucumber jasmine") | |
| sh("bundle exec rake ci") |
But not a blocker.
There was a problem hiding this comment.
Sure, this could work but may need some refinement.
I don't like the idea of it being ci as pact:verify will be also a part of CI. Could call it jenkins_ci, but that couples it to Jenkins. I suppose could be ci_build hmmm. I also wonder if it's actually better to be direct in the Jenkinsfile and whether adding another task ends up being misdirection.
There was a problem hiding this comment.
Fair point 👍 happy to leave as-is.
Realised I should have added this in: #7094
Trello: https://trello.com/c/QrxjshEm/270-move-ruby-gems-from-jenkins-to-github-actions
This moves the pact verification to a GitHub Action and will no longer be performed by a Jenkins build. This workflow will also be called by GDS API Adapters as part of its CI build to assert that newly generated pacts are valid against this app. To avoid running this same task twice
pact:verifyis no longer part of the Jenkins test actions and instead the other rake default steps are included.For more details see alphagov/gds-api-adapters#1175
Follow these steps if you are doing a Rails upgrade.