Fix bug with update_lead_image method #8434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'and return if' isn't returning when the image_display_option is no_image or organisation_image. This means that when an image is created and the lead_image isn't set the assoication is created. It still wouldn't be pushed downstream to Publishing API, but we shouldn't have lead images sitting in the db when there isn't a lead image. This updates the method to explicitly call return within the conditional which resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'and return if' isn't returning when the
image_display_optionisno_imageororganisation_image.This means that when an image is created and the lead_image isn't set the association is created.
It still wouldn't be pushed downstream to Publishing API as the presenter handles passing the image based on the
image_display_option, but we shouldn't have lead images sitting in the db when there isn't a lead image.This updates the method to explicitly call return within the conditional which resolves the issue.
Trello card
https://trello.com/c/5vCiIxeQ/1064-lead-image-handling-backend-work
Follow these steps if you are doing a Rails upgrade.