Remove Ghostscript and PDF thumb generation. #9163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gov-frontend no longer uses PDF thumbnails, so we can drop Ghostscript etc. For now, we keep the (probably disused) thumbnail_url field and use the "fallback" icon for new PDFs. Can probably remove the field and the icon altogether soon after.
sengi
added
the
security
ryanb-gds
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gov-frontend no longer uses PDF thumbnails, so we can drop Ghostscript etc.
For now, we keep the (probably disused) thumbnail_url field and use the "fallback" icon for new PDFs. Can probably remove the field and the icon altogether soon after.
Fixes #7480.
See also:
https://trello.com/c/vjSowrs7 (dup)
https://trello.com/c/oh4MXlUA (related)