Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(629) Update summary cards #9588

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

pezholio
Copy link
Contributor

@pezholio pezholio commented Nov 6, 2024

This updates the summary cards on the homepage, as well as some tweaks to the copy.

Screenshot

image

@pezholio pezholio requested a review from Harriethw November 6, 2024 11:43
@pezholio pezholio force-pushed the content-modelling/629-update-summary-cards branch 5 times, most recently from a38488c to f75eb04 Compare November 6, 2024 12:39
@pezholio pezholio marked this pull request as draft November 6, 2024 16:31
@pezholio pezholio force-pushed the content-modelling/629-update-summary-cards branch 4 times, most recently from f82ebb1 to 15bec3a Compare November 7, 2024 10:02
@pezholio pezholio marked this pull request as ready for review November 7, 2024 10:03
@pezholio pezholio force-pushed the content-modelling/629-update-summary-cards branch 3 times, most recently from b0dbcb9 to a0bc929 Compare November 7, 2024 10:12
Copy link
Contributor

@Harriethw Harriethw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! my only request is would it be possible to get the columns aligned? This bothers me 😅
383913159-8577fa6b-da6b-46f2-bbec-5d983bbf90a5

@pezholio pezholio force-pushed the content-modelling/629-update-summary-cards branch from a0bc929 to 5317534 Compare November 11, 2024 08:58
This shows when the item was last updated in words, as well as the user
who made the change.
This adds an `items` method, which returns a subset of the items in the
summary list component.
This matches the approved designs
This builds on the [Accordion component](https://components.publishing.service.gov.uk/component-guide/accordion)
and applies some custom styling. I’ve also updated the tests to check
the panels are expanded when a filter is present.
@pezholio pezholio force-pushed the content-modelling/629-update-summary-cards branch from 5317534 to bea08ab Compare November 11, 2024 08:59
@pezholio pezholio enabled auto-merge November 11, 2024 08:59
@pezholio pezholio merged commit b67d517 into main Nov 11, 2024
19 checks passed
@pezholio pezholio deleted the content-modelling/629-update-summary-cards branch November 11, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants