Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate add another usage to govuk_publishing_components impementation #9644

Merged

Conversation

dnkrj
Copy link
Contributor

@dnkrj dnkrj commented Nov 22, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

  • Migrate the 5 usages of the add-another pattern in Whitehall to the the govuk_publishing_components implementation introduced in govuk_publishing_components/pull/4420

Why

Screenshots

Before After
whitehall-admin integration publishing service gov uk_government_admin_organisations_government-digital-service_edit(iPad Pro) whitehall-admin dev gov uk_government_admin_organisations_government-digital-service_edit(iPad Pro)

Copy link
Contributor

@ryanb-gds ryanb-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the items passed to the add another component aren't hugely readable - I wonder if we might make use of some intermediate variables to build the items before we pass them to the components. Definitely not a show stopper though

@dnkrj dnkrj force-pushed the 3139-move-add-another-pattern-to-govukpublishingcomponents branch from 884068c to bbbe8a4 Compare November 25, 2024 17:27
@dnkrj dnkrj force-pushed the 3139-move-add-another-pattern-to-govukpublishingcomponents branch from bbbe8a4 to d89cce2 Compare November 28, 2024 13:55
@dnkrj dnkrj force-pushed the 3139-move-add-another-pattern-to-govukpublishingcomponents branch 13 times, most recently from d06e13b to 10cb8e5 Compare November 28, 2024 17:12
dependabot bot and others added 7 commits November 29, 2024 13:50
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 45.6.1 to 46.0.0.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v45.6.1...v46.0.0)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
This has been moved to `govuk_publishing_components` so no longer needs to be defined in Whitehall.
Call the new publishing components add another template for contact numbers
Call the new publishing components add another template for casualties
Call the new publishing components add another template for social media accounts
Call the new publishing components add another template for featured links
Call the new publishing components add another template for promotional feature links
@dnkrj dnkrj force-pushed the 3139-move-add-another-pattern-to-govukpublishingcomponents branch from 10cb8e5 to cdb1f08 Compare November 29, 2024 13:51
@dnkrj dnkrj merged commit bc45ecc into main Nov 29, 2024
19 checks passed
@dnkrj dnkrj deleted the 3139-move-add-another-pattern-to-govukpublishingcomponents branch November 29, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants