-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate add another usage to govuk_publishing_components impementation #9644
Merged
dnkrj
merged 7 commits into
main
from
3139-move-add-another-pattern-to-govukpublishingcomponents
Nov 29, 2024
Merged
Migrate add another usage to govuk_publishing_components impementation #9644
dnkrj
merged 7 commits into
main
from
3139-move-add-another-pattern-to-govukpublishingcomponents
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb-gds
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the items passed to the add another component aren't hugely readable - I wonder if we might make use of some intermediate variables to build the items before we pass them to the components. Definitely not a show stopper though
dnkrj
force-pushed
the
3139-move-add-another-pattern-to-govukpublishingcomponents
branch
from
November 25, 2024 17:27
884068c
to
bbbe8a4
Compare
dnkrj
force-pushed
the
3139-move-add-another-pattern-to-govukpublishingcomponents
branch
from
November 28, 2024 13:55
bbbe8a4
to
d89cce2
Compare
dnkrj
force-pushed
the
3139-move-add-another-pattern-to-govukpublishingcomponents
branch
13 times, most recently
from
November 28, 2024 17:12
d06e13b
to
10cb8e5
Compare
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 45.6.1 to 46.0.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v45.6.1...v46.0.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This has been moved to `govuk_publishing_components` so no longer needs to be defined in Whitehall.
Call the new publishing components add another template for contact numbers
Call the new publishing components add another template for casualties
Call the new publishing components add another template for social media accounts
Call the new publishing components add another template for featured links
Call the new publishing components add another template for promotional feature links
dnkrj
force-pushed
the
3139-move-add-another-pattern-to-govukpublishingcomponents
branch
from
November 29, 2024 13:51
10cb8e5
to
cdb1f08
Compare
dnkrj
deleted the
3139-move-add-another-pattern-to-govukpublishingcomponents
branch
November 29, 2024 14:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
govuk_publishing_components
implementation introduced in govuk_publishing_components/pull/4420Why
Screenshots