Add support for landing page images in image / featured blocks #9662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support for "landing page" images, which are a different size to the default images in whitehall.
These can be used in two types of "block" - the image block, and the featured block. The code to present these blocks is updated to transform:
[Image: blah.png]
to the appropriate asset URLs, as we do for the hero blocks.Largely for consistency with hero blocks, the config we're expecting users to write is:
However, as the aspect ratios of each image are the same (just different sizes), rather than adding three image kinds with two variants (1x / 2x) each, I've just added one image kind with six variants. Since we don't need or want to do art direction, I expect that we'll just upload one image and use it for all three sources (desktop / tablet / mobile).
It might be better in future just to do
source:
instead ofsources:
for these images, but I think that's a change which will likely confuse us at this point, so I'm sticking with the same structure as heros.I'll update our blocks documentation once this merges.
Screenshots