(746) Update preview email address screen in the edit journey #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than repeating ourselves, let’s use a helper method
Additionally, display `0` if there are no page views present for a host edition.
This makes it clearer what the purpose of the page is
Harriethw
reviewed
Dec 4, 2024
| @@ -47,6 +47,11 @@ def update | |||
| end | |||
| end | |||
|
|
|||
| def context | |||
There was a problem hiding this comment.
I do wonder whether we should be a bit better at having microcopy like this in translation files. It's always one of those things that you start off thinking it's not worth doing, then as a project gets bigger you wish you'd have done sooner!
Harriethw
approved these changes
Dec 4, 2024
pezholio
deleted the
content-modelling/746-update-preview-email-address-screen-in-the-edit-journey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a bunch of minor copy changes to the preview section of the Content Modelling edit journey
Screenshot