Refactoring: Reduce usages of sti_name to minimum #9746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngocd
force-pushed
the
remove_sti_name
branch
from
488da0f to
44297c7
Compare
sti_names methods don't seem to be used anywhere and can be removed. within Edition::Identifiable: * When edition is saved, the edition type should be propogated to the document type. Additionally the document_type on an Edition is being used in multiple places so is not easy to unpick. The published as class method is used to fetch document by slug based on the type of the subclass. So unfortunately we still need to use sti_name for this. * The test however has 1 duplicate unecessary test, as we not only support News and Speeches sharing same slug, but all other document types too, which already has another test above covering that.
minhngocd
force-pushed
the
remove_sti_name
branch
from
44297c7 to
deaa70c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sti_namesmethods don't seem to be used anywhere and can be removed.within Edition::Identifiable:
https://trello.com/c/EewW5W4A/3264-delete-selfstinames-methods
Follow these steps if you are doing a Rails upgrade.