Content modelling/748 add review page to the reschedule journey #9747
+75
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this separates out the journeys that use the edit link to change existing scheduled blocks (via the schedule controller), compared to schedulinga block initially or using the normal edit forms flow - as the file was getting a bit hard to follow.
we will shortly use the same method in the schedule controller
will shortly be used by the schedule controller
now that we have the shared validation of the schedule data and the edition under change, we can flow back into the regular workflow controller.
Base automatically changed from
content-modelling/748-add-review-to-edit
to
main
December 17, 2024 16:02
Harriethw
commented
Dec 17, 2024
| @@ -0,0 +1,46 @@ | |||
| Feature: Schedule a content object | |||
| Background: | |||
| Given I am a GDS admin | |||
There was a problem hiding this comment.
this move might be a bit controversial but thought it worth getting some feedback on
There was a problem hiding this comment.
Nah, I think it makes total sense
pezholio
approved these changes
Dec 17, 2024
| @@ -0,0 +1,46 @@ | |||
| Feature: Schedule a content object | |||
| Background: | |||
| Given I am a GDS admin | |||
There was a problem hiding this comment.
Nah, I think it makes total sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged once this approved: #9735
Adds the
reviewpage to the rescheduling journey, with some refactoring along the way.Follow these steps if you are doing a Rails upgrade.