Fix bugs with the link predicate #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirak
changed the title
This was referenced Jun 13, 2021
|
Thanks, Akira. I'll start with the tests, then look toward merging the fixes. |
alphapapa
force-pushed
the
fix/link-pred-bugs
branch
from
e11045e to
6422f84
Compare
alphapapa
pushed a commit
that referenced
this pull request
Jun 16, 2021
alphapapa
force-pushed
the
fix/link-pred-bugs
branch
from
6422f84 to
18dbb98
Compare
alphapapa
added a commit
that referenced
this pull request
Jun 16, 2021
NOTE: Due to changes between 0.5 and 0.6, the fixes don't merge cleanly, so they will be applied in subsequent commits. See #220.
|
I think that should do it. Thanks very much for catching this, Akira! Please let me know if you find any more issues. |
US-Thakur
pushed a commit
to US-Thakur/merge_testing
that referenced
this pull request
Mar 14, 2022
Closes alphapapa/org-ql#222. See also alphapapa/org-ql#220. Thanks to Akira Komamura (@akirak).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I found some bugs in
:linkpredicate while I was working on my own package. Below are the issues, which are fixed in this PR::targetdoes not work, and org-ql returns an unfiltered result, i.e. all entries containing a link.:regexp-pto t and pass a regular expression as an argument, org-ql returns an empty result.