Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable further lookups when no definition found #541

Closed
balmas opened this issue Oct 15, 2020 · 6 comments
Closed

enable further lookups when no definition found #541

balmas opened this issue Oct 15, 2020 · 6 comments
Labels
bug Something isn't working enhancement New feature or request question Further information is requested user report verified

Comments

@balmas
Copy link
Member

balmas commented Oct 15, 2020

Requested by @rgorman

Because of the date and subject matter of the text (and Marcus' own annoying predilection for obscure technical terms), many words are returned by Alph. as "no definitions found." In the nature of things, many of these are compounds. E.G., πρό-ἀπολέγω. It would be great if we could click on either part of the lemma and be taken to the dictionary entry, since it is easy to guess the meaning of a compound from its parts, usually.

Similarly, Alph. sometimes says that the definition for some late term is the same as an earlier term (new = old, is the usual form). It would be great if we could call up the dictionary entry to the old form from this window.

@balmas balmas added bug Something isn't working enhancement New feature or request labels Oct 15, 2020
@balmas balmas self-assigned this Dec 9, 2020
balmas pushed a commit to alpheios-project/fixtures that referenced this issue Dec 10, 2020
balmas pushed a commit to alpheios-project/fixtures that referenced this issue Dec 10, 2020
balmas pushed a commit that referenced this issue Dec 11, 2020
make lemma parts in the popup alpheios-enabled for lookup
@balmas balmas mentioned this issue Dec 11, 2020
balmas pushed a commit that referenced this issue Dec 11, 2020
balmas added a commit that referenced this issue Dec 11, 2020
balmas pushed a commit that referenced this issue Dec 11, 2020
activate text selector on short definitions always (only has effect on alpheios-enabled elements)
make sure styling applies to sub elements of the short definition
make the cursor a pointer on any alpheios-enabled elements
@balmas
Copy link
Member Author

balmas commented Dec 11, 2020

Another test case for this: ἐπεκυλίνδουν

balmas pushed a commit that referenced this issue Dec 11, 2020
activate text selector on short definitions always (only has effect on alpheios-enabled elements)
make sure styling applies to sub elements of the short definition
make the cursor a pointer on any alpheios-enabled elements
balmas added a commit that referenced this issue Dec 14, 2020
@balmas balmas closed this as completed Dec 14, 2020
@balmas
Copy link
Member Author

balmas commented Jan 8, 2021

the fix to enable lookups on compound lemmas can be tested in Alpheios Components 3.3.1-qa.20210108437

lookups on greek words in definitions requires updated defs files, shoube tested via those issues.

@monzug
Copy link
Contributor

monzug commented Jan 12, 2021

ἐπεκυλίνδουν -

  1. in the pop-up, can we highlight only the compound part that has been selected ( ἐπε or κυλίνδουν ) not the all word?

  2. Would it be possible in this case to keep the original pop-up open so I can select also the other compound word (like nesting)? right now, when I click on ἐπε , a new pop-up is generated and the original one is gone. if I want to lookup for the second word κυλίνδουν, I have to enter the ἐπεκυλίνδουν word again.

@monzug monzug assigned balmas and unassigned monzug Jan 12, 2021
@monzug monzug added question Further information is requested and removed waiting_verification labels Jan 12, 2021
@monzug monzug reopened this Jan 12, 2021
@balmas
Copy link
Member Author

balmas commented Jan 13, 2021

Would it be possible in this case to keep the original pop-up open so I can select also the other compound word (like nesting)? right now, when I click on ἐπε , a new pop-up is generated and the original one is gone. if I want to lookup for the second word κυλίνδουν, I have to enter the ἐπεκυλίνδουν word again.

For this we really need session history, which will be part of the next major release

@balmas
Copy link
Member Author

balmas commented Jan 13, 2021

in the pop-up, can we highlight only the compound part that has been selected ( ἐπε or κυλίνδουν ) not the all word?

I think that change is too big for the incremental too unfortunately. The selection code is tricky. I'm going to enter a new issue for it to be considered for the future.

@monzug
Copy link
Contributor

monzug commented Jan 13, 2021

will close this one as all questions have been addressed in new issues. Thanks

@monzug monzug removed their assignment Jan 13, 2021
@monzug monzug closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested user report verified
Projects
None yet
Development

No branches or pull requests

2 participants