This repository has been archived by the owner on Feb 12, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
remove flexible positioning popup option #634
Comments
agree |
balmas
changed the title
popup flexible positioning broken
remove flexible positioning popup option
Jul 1, 2019
balmas
added a commit
that referenced
this issue
Jul 1, 2019
webextension qa-3.0.0.44/embed-lib 1.0.0.26 |
hmm. in build qa-3.0.0.49 I can move the popup in FF but not the overlay toolbar. @monzug do you see the same? |
build 3.0.0.49 in FF |
ok, assigning to @kirlat . Thanks. |
actually, I think it's better as a new issue. Not sure it's related to this fix at all. |
yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I think the changes to remember the popup position (#468) broke the flexible positioning option for the popup. If that's set, the shift gets set to 0,0 and it no longer tries to position itself at the location of the click. I'm tempted to just get rid of that feature because it was difficult to get right which is why it wasn't the default. I think maybe the ability to remember where a user last put the popup makes this less necessary anyway too.
@monzug @abrasax what are your thoughts about this? Could we abandon that feature for now?
The text was updated successfully, but these errors were encountered: