Skip to content
This repository has been archived by the owner on Feb 12, 2020. It is now read-only.

remove flexible positioning popup option #634

Closed
balmas opened this issue Jun 20, 2019 · 9 comments
Closed

remove flexible positioning popup option #634

balmas opened this issue Jun 20, 2019 · 9 comments
Labels
bug Something isn't working verified passed qa

Comments

@balmas
Copy link
Member

balmas commented Jun 20, 2019

I think the changes to remember the popup position (#468) broke the flexible positioning option for the popup. If that's set, the shift gets set to 0,0 and it no longer tries to position itself at the location of the click. I'm tempted to just get rid of that feature because it was difficult to get right which is why it wasn't the default. I think maybe the ability to remember where a user last put the popup makes this less necessary anyway too.

@monzug @abrasax what are your thoughts about this? Could we abandon that feature for now?

@balmas balmas added the question Further information is requested label Jun 20, 2019
@monzug
Copy link

monzug commented Jun 22, 2019

agree

@balmas balmas changed the title popup flexible positioning broken remove flexible positioning popup option Jul 1, 2019
@balmas balmas added the bug Something isn't working label Jul 1, 2019
@balmas balmas self-assigned this Jul 1, 2019
@balmas balmas removed the question Further information is requested label Jul 1, 2019
@balmas balmas closed this as completed in b0bb4c5 Jul 1, 2019
@balmas balmas assigned monzug and unassigned balmas Jul 3, 2019
@balmas
Copy link
Member Author

balmas commented Jul 3, 2019

webextension qa-3.0.0.44/embed-lib 1.0.0.26

@monzug
Copy link

monzug commented Jul 29, 2019

I am not sure if this is a side effect of the above change but in FF I cannot move the morphology pop-up (and the flex nav) anymore. Note that Chrome works fine. see screenshot (I cannot reach the bottom of the pop-up)
cannot-move-the-popup

@monzug monzug reopened this Jul 29, 2019
@monzug monzug assigned balmas and unassigned monzug Jul 29, 2019
@balmas
Copy link
Member Author

balmas commented Jul 30, 2019

hmm. in build qa-3.0.0.49 I can move the popup in FF but not the overlay toolbar. @monzug do you see the same?

@monzug
Copy link

monzug commented Jul 30, 2019

@balmas
Copy link
Member Author

balmas commented Jul 30, 2019

ok, assigning to @kirlat . Thanks.

@balmas balmas assigned kirlat and unassigned balmas Jul 30, 2019
@balmas
Copy link
Member Author

balmas commented Jul 30, 2019

actually, I think it's better as a new issue. Not sure it's related to this fix at all.

@balmas
Copy link
Member Author

balmas commented Jul 30, 2019

@monzug the new issue is #712. Can we close this one?

@monzug
Copy link

monzug commented Jul 30, 2019

yes

@monzug monzug closed this as completed Jul 30, 2019
@monzug monzug removed their assignment Jul 30, 2019
@monzug monzug added the verified passed qa label Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified passed qa
Projects
None yet
Development

No branches or pull requests

3 participants