Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make x-show wait for children to finish transitioning #177

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

calebporzio
Copy link
Collaborator

Given a nested x-show with the child having a transition out:

<div x-show="open">
  <div x-show="open" x-transition:leave="some-slow-transition">

Before, we wouldn't see the transition out on the child because the parent would hide immediately.

NOW, every x-show will wait for its children to finish hiding before it hides itself.

You can forgo this functionality by adding the .immediate modifier:

<div x-show.immediate="open">
  <div x-show="open" x-transition:leave="some-slow-transition">

@calebporzio calebporzio merged commit c58eb6b into master Feb 13, 2020
@calebporzio calebporzio deleted the make-x-show-wait-for-transitions branch March 17, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant