Improve x-attributes regexp #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippbosch
force-pushed
the
better-isxattr
branch
from
e5d1baf to
a7b4e5f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging reasons I tried to disable an
x-showby changing it toblah-x-showand was surprised it was still parsed likex-show.The reason was that the regular expression used to filter all attributes was a bit too loose. My suggestion implemented in this PR is to:
x-and does not allow any extraneous characters before thex. This is done by adding a start of string anchor to the beginning:/^x-…instead of/x-…x-showblah). This is done by adding a word boundary (\b) to the end of the regexp. Using a word boundary instead of an end of string anchor ($) allows for values (:click) and modifiers (.prevent).Any suggestions welcome and appreciated.