🐛 Fixes proxy stack setters bug #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3804
This was a regression in the behaviors from the merge proxy optimization.
This still seems problematic in many ways. but this more faithfully represents the older logic.
If there is a getter setter pair, the
thisrefers to the proxy stack. If it's just a setter, it doesn't (this was how the original logic worked).Similarly to before, using getters/settings/methods,etc on the parent component can modify the child component when keys match. Not great, but that's how it has been.
It could be possible to instead limit it only to that level and parents, but that would change the behavior.
This also adds tests to ensure this continues to work :)