Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add range type to x-model inputs #3911

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

peterfox
Copy link
Contributor

@peterfox peterfox commented Dec 9, 2023

Changes

  • Adds range input to examples in model.md documentation

Why

I've been playing around with the range input type with AlpineJS and there seems to be no issue. It feels sensible to add it to the docs as a supported input type.

@ekwoka
Copy link
Contributor

ekwoka commented Dec 9, 2023

Makes sense. All inputs work (even custom ones that conform to the dom specs)!

@peterfox
Copy link
Contributor Author

peterfox commented Dec 9, 2023

@ekwoka I assume that's the case but when looking at the docs it makes it seem like only those limited inputs will work from the way it's worded.

@ekwoka
Copy link
Contributor

ekwoka commented Dec 9, 2023

Agreed. Might be worth making an earlier callout that it is supposed to work correctly with all native controls and custom controls that follow standards.

But then again, nobody reads the docs that closely 😂

@calebporzio calebporzio merged commit 3d75916 into alpinejs:main Dec 11, 2023
1 check passed
@calebporzio
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants