Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix __noscroll param #4063

Merged
merged 1 commit into from
Mar 4, 2024
Merged

bug fix __noscroll param #4063

merged 1 commit into from
Mar 4, 2024

Conversation

theGC
Copy link
Contributor

@theGC theGC commented Mar 1, 2024

fix to allow preventScroll to be set to true when element passed onScroll() method

Copy link
Contributor

@ekwoka ekwoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow!

Obligatory: TypeScript would have caught this.

@calebporzio
Copy link
Collaborator

lol @ekwoka, it had to be said!

Thanks @theGC

@calebporzio calebporzio merged commit 2dacee0 into alpinejs:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants