Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enhances clicks with key modifiers #4209

Merged
merged 5 commits into from
May 16, 2024

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented May 14, 2024

Handles #4208

Allows for the use of ctrl meta...etc keys on click and mouse event listeners.

Overall simple change to include clicks

Would a more significant refactor also enable the use of mouse-button modifiers? Maybe...

This also solved some potential bugs related to modifiers that could exist on a keydown that wouldn't be properly ignored.

Includes:

  • Tests
  • Doc Updates

@ekwoka ekwoka changed the title Enhance key modifiers on clicks ✨ Enhances clicks with key modifiers May 14, 2024
@calebporzio
Copy link
Collaborator

Love this! Thanks @ekwoka!

@calebporzio calebporzio merged commit 4fa8eaf into alpinejs:main May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants