Update transition.md - changed span to div #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a span, the transition effect is not obvious because the element doesn't move so the documentation looks broken. I confirmed this in MacOS for Firefox, Chrome, and Safari.
|
Good call - thanks! |
This was referenced Jun 13, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 21, 2024
Open
Open
Open
Open
Open
Open
This was referenced Jun 29, 2024
Open
Open
Open
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 21, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 29, 2024
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a span, the transition effect is not obvious because the element doesn't move so the documentation looks broken.
I confirmed this in MacOS for Firefox, Chrome, and Safari.