Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes issue with setters accessing deeply nested data #4265

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented Jun 14, 2024

Solves an issue presented in Discord

Apparently there is an upstream bug in @vue/reactivity that, when using a setter to access deeply nested data on a part of this that was not in the same object, would error out. As vue was not respecting the this context when using reflection.

I intend to make a PR there to address this as well, but Alpine is broken by even updating one minor version, so this still needs to be addressed here.

The issue can be demonstrated here:

3.13.0

3.13.1

😞

@calebporzio
Copy link
Collaborator

Ooof, this is great stuff, thank you @ekwoka

@calebporzio calebporzio merged commit 541cb8e into alpinejs:main Jun 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants