-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for existence of parent component first when filtering mutations #91
Conversation
Suppresses an error caused by the parent component being null in some cases.
Also rebuild dist.
Hey @thormeier - what are the cases where it's null? |
See #90 - I wasn't able to fully understand the interdependence between Choices and Alpine, but I'm almost sure it happens when the mutation target is removed from the DOM before the observer is triggered. That's at least what my observation yielded. |
I should have read through the PRs first, but I just ran into this same problem and raised and issue #110 I get a similar issue when I have the WhatFont Chrome extension enabled. |
+1 Get this error as well. Running Chrome in Incognito Mode fixes the issue. |
Thanks @thormeier. Any chance you can write a test that simulates this behavior? I merged it, but because no test will fail if I roll it back - it could be refactored out in the future and the error could crop back up again. Thanks. |
@calebporzio Sure thing, will do a follow-up PR on this. |
@calebporzio Added a test here: #126 |
Add test for PR #91 regarding disconnected nodes and fix same issue while listening for new components.
Suppresses an error caused by the parent component being null in some
cases.
Fixes #90.