-
Notifications
You must be signed in to change notification settings - Fork 692
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
community/nodejs-current: switch to python3 for building
- Loading branch information
Showing
2 changed files
with
51 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
community/nodejs-current/fix-gyp-python3-incompatibility.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
From c0282daa48cf1803c4283998304c563390866c8d Mon Sep 17 00:00:00 2001 | ||
From: cclauss <cclauss@me.com> | ||
Date: Sun, 27 Oct 2019 17:42:31 +0100 | ||
Subject: [PATCH] gyp: iteritems() -> items() in compile_commands_json.py | ||
|
||
PR-URL: https://github.com/nodejs/node-gyp/pull/1947 | ||
Reviewed-By: Jiawen Geng <technicalcute@gmail.com> | ||
Reviewed-By: Richard Lau <riclau@uk.ibm.com> | ||
--- | ||
gyp/pylib/gyp/generator/compile_commands_json.py | 6 +++--- | ||
1 file changed, 3 insertions(+), 3 deletions(-) | ||
|
||
diff --git a/tools/gyp/pylib/gyp/generator/compile_commands_json.py b/tools/gyp/pylib/gyp/generator/compile_commands_json.py | ||
index 575db63c4..1b8490451 100644 | ||
--- a/tools/gyp/pylib/gyp/generator/compile_commands_json.py | ||
+++ b/tools/gyp/pylib/gyp/generator/compile_commands_json.py | ||
@@ -43,7 +43,7 @@ def CalculateVariables(default_variables, params): | ||
|
||
def AddCommandsForTarget(cwd, target, params, per_config_commands): | ||
output_dir = params['generator_flags']['output_dir'] | ||
- for configuration_name, configuration in target['configurations'].iteritems(): | ||
+ for configuration_name, configuration in target['configurations'].items(): | ||
builddir_name = os.path.join(output_dir, configuration_name) | ||
|
||
if IsMac(params): | ||
@@ -92,7 +92,7 @@ def resolve(filename): | ||
|
||
def GenerateOutput(target_list, target_dicts, data, params): | ||
per_config_commands = {} | ||
- for qualified_target, target in target_dicts.iteritems(): | ||
+ for qualified_target, target in target_dicts.items(): | ||
build_file, target_name, toolset = ( | ||
gyp.common.ParseQualifiedTarget(qualified_target)) | ||
if IsMac(params): | ||
@@ -102,7 +102,7 @@ def GenerateOutput(target_list, target_dicts, data, params): | ||
AddCommandsForTarget(cwd, target, params, per_config_commands) | ||
|
||
output_dir = params['generator_flags']['output_dir'] | ||
- for configuration_name, commands in per_config_commands.iteritems(): | ||
+ for configuration_name, commands in per_config_commands.items(): | ||
filename = os.path.join(output_dir, | ||
configuration_name, | ||
'compile_commands.json') |