testing/code-server: new aport #9235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please use our commit naming scheme |
|
Also check drone-ci and fix the failures pointed out |
maxice8
reviewed
Jul 1, 2019
testing/code-server/APKBUILD
Outdated
| url="https://github.com/cdr/code-server" | ||
| arch="all" | ||
| license="MIT" | ||
| depends="" |
There was a problem hiding this comment.
empty variables can be removed for brevity
maxice8
reviewed
Jul 1, 2019
testing/code-server/APKBUILD
Outdated
| arch="all" | ||
| license="MIT" | ||
| depends="" | ||
| makedepends="yarn npm python2" |
There was a problem hiding this comment.
Please use python3 as python2 will soon be EOL
maxice8
reviewed
Jul 1, 2019
testing/code-server/APKBUILD
Outdated
| subpackages="" | ||
| source="$pkgname-$_fullver.tar.gz::https://github.com/cdr/code-server/archive/$_fullver.tar.gz" | ||
| builddir="$srcdir/$pkgname-$_fullver" | ||
| options="!check" |
There was a problem hiding this comment.
Please add a comment on why check is disabled
wenerme
changed the title
|
py3 will failed node-gyp, newer node-gyp need upstream upgrade nodejs/node-gyp#1687 node-gyp support py3 lately. |
mor1
pushed a commit
to mor1/aports
that referenced
this pull request
Nov 8, 2019
…2018-19661, CVE-2018-19662) This is upstream commit 8ddc442d539ca775d80cdbc7af17a718634a743f Partially fixes alpinelinux#9235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.