testing/bcc: split into subpackages #9937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg-config files should be in -dev. |
|
Fixed. Thanks. |
maxice8
reviewed
Aug 25, 2019
maxice8
reviewed
Aug 26, 2019
maxice8
reviewed
Aug 26, 2019
maxice8
reviewed
Aug 26, 2019
acj
force-pushed
the
bcc-subpackages
branch
3 times, most recently
from
9fc309d
to
85838a7
Compare
maxice8
reviewed
Aug 27, 2019
maxice8
reviewed
Aug 27, 2019
kaey
reviewed
Aug 27, 2019
testing/bcc/APKBUILD
Outdated
| @@ -33,6 +34,28 @@ build() { | |||
| package() { | |||
| cd "$builddir/build" | |||
| make install DESTDIR="$pkgdir" | |||
|
|
|||
| mv "$pkgdir"/usr/share/bcc/man "$pkgdir"/usr/share/man | |||
There was a problem hiding this comment.
Tools which these man pages refer to are not in PATH, so it's better to leave them in /usr/share/bcc/man.
Furthermore in a shared space they would conflict with man pages provided by bpftrace
There was a problem hiding this comment.
Fair enough. Moved them back
|
Merged in 34aa41f by @maxice8. Thanks for your contribution! (This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that libbpf has releases, I'm including it as part ofSee discussion below.sourceto simplify the build and patches.