Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add formatting and linting #148

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Mar 6, 2023

As talked about in #143, here are some linting and formatting checks for the nix code :)

  • formatting checks
  • linting checks
  • pre-commit-hooks
  • corresponding devShell
  • CI entry
  • README has been updated
  • gitignore has been updated

Note
if the user chooses to use the devShell for development of this flake, this will
install a pre-commit-hook that will be required to be run before commiting, this can
be skipped with --no-verify (as stated in the README)

Warning
We now implicitly depend on flake-utils again, but perhaps this is not an issue...
Also note that we perhaps at some point want to check spelling in the REAMDE but I
didn't have time to setup hunspell for it

- formatting checks
- linting checks
- pre-commit-hooks
- corresponding devShell
- CI entry
Copy link
Collaborator

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MangoIV , Thanks a lot! This looks very useful. 👍

@supersven supersven merged commit d1375f4 into alpmestan:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants