-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium Logos and sources #207
Comments
@Alex313031 I have updated the title for #206 so it's clear that Chromium is also part of that discussion.
Glad you found it useful!
It's usually one of the following:
Image optimization is a very complex topic that I will not go into here. That being said, in essence, those commits are usually related to reducing the size of the file by removing unneeded metadata and re-encoding the file in a more efficient way. In the case of SVGs, it's also about reducing complexity so they are rendered faster.
The commit message will specify if it's lossless. If it's not, I usually make sure the difference is not noticeable. Closing this issue in favor of #206. |
From #206 (comment):
@Alex313031 ℹ️ If, for example, you use Google image search, you can add |
I saw the issue regarding the chrome logo, just reminding you to do chromium too. I make my own Chromium fork for linux, win, and macos called Thorium > https://github.com/Alex313031/Thorium/ And I used your chromium svg as a starting point for editing the logo in gimp to make the thorium logo. I rendered it at 8192x8192, added black to the inner ring, and then exported as .png to the various sizes needed for the the logo in the chromium source code for various platforms. So thanks for this project. I also used the webview-dev icon for content_shell, which is something I added to the installer for thorium, normally only built by a seperate flag when building, and also normally not included in the installer, but useful for debugging. I also added chromedriver.
Second thing is a question; how are you getting these? You have resolutions of the chromium logo that I cant find anywhere else on the net, and especially the svg. I couldnt find svgs for many of the browser logos you have. It's all a very useful repo, but I'm just scratching my head like how did you source some of these?
Third thing is also a question, when you make a commit saying something has been "optimized" like in the recent nodejs commit, what does that mean? Compression? Color optimization? If its compression I hope its lossless lol.
The text was updated successfully, but these errors were encountered: