-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG version of the Safari logo #200
Conversation
This is created from scratch in Inkscape, working from the 512x512px .png version. I've attempted to minimize the diff with that when this SVG is exported to .png at that resolution.
Great work, @eoghanmurray! 👏 This is the closest to the original I've seen so far! At first glance 2 main differences stand out to me: @eoghanmurray Would you be willing / have the time to work on improving the things mentioned above? |
- dial lines no longer cut off (gaussiann shadow didn't have enough margin - redraw of background blue gradient, albeit still not perfect in lower left/right quadrants (I dunno how the original gradient was done)
Thanks for the review, amazing that someone cares about these details!
I wish you had accepted some of the previous efforts, perhaps under a different filename, e.g. Also, is there any space for the workings, e.g. safari.inkscape.svg — future corrections would be easier to do in that rather than in the optimized version I've added here. |
@eoghanmurray Thank you! 🙇♂️
I think it's good. 👍 One last thing and this should be good to merge: The PNG version of the logo is embedded as a data URI in the SVG. That should be removed, however, once removed 2 of the dial lines lose their shadow.
There are many reasons why I do not, the main ones being:
In general this project tries as much as possible to match the official logos. Quite often they are provided by the official source (see: [1], [2], [3], etc.). Unfortunately, that has not been the case with Apple (see: [1], [2]). 😔
The code from the previous attempts is still available. Also, I did attach an even "closer to the original" version once I found it.
I would recommend making a zip archive and attaching it to this issue. |
Workings attached! |
P.s. thanks for the explanations |
@eoghanmurray Thank you!
@eoghanmurray Would you be willing / have the time to work on the above mentioned? |
Whatever way I removed the accidentally embedded image, I didn't seem to lose any of those shadows. This is the latest from this pull request: |
@eoghanmurray Thank you for taking the time to do this! Great work! 👏 This is now merged in: 260d24e. Note: To correct the shadow issue mentioned above, but also to reduce among other the number of transforms, I redid the dial lines. Also, I tweak some other minor things and further optimized the SVG.
@eoghanmurray If you look a bit more carefully (or enlarge the SVG), you will see them. Here is a picture of only the dial lines to make it more clearer: |
Also, regenerate the PNG images based on the SVG. Ref: #200
Are transforms negative from a performance point of view? I was using the Also I'm wondering about the regeneration of the .pngs; I assumed they were the source images taken from iOS directly. Regenerating them erases the memory that the SVG gradient isn't perfectly correct. |
@eoghanmurray Yes. For example in Chrome, rendering takes twice as much for the SVG with all the transforms (note: throttle the CPU to make the difference even more visible).
Using the
Having discrepancies between the images creates confusion and that leads to more issues. Every time a SVG is changed, I regenerate the related PNGs. This is not something new (see for example: bd90dba).
That's why we us Git (see: old icons).
If you have the time and want to tweak things even more, feel free! I would gladly accept the pull request! @eoghanmurray Thank you again for this work! |
Ok just wondering if there's a way I can identify an official source .png image at the highest resolution in order to base future redraws of SVGs off of? |
@eoghanmurray It depends. If the logo is not directly provided by the official source (such as in the case of the V8 related ones), things are not always straightforward. For example, many browsers use variations of their logos depending on the platform, year, etc. Here is the current UC browser logo on Android: or the current Chrome browser logo on macOS ...and there are many other examples like the above. If the logo is not directly provided, it will still be indirectly provided with the browser, on the official site, etc. (see for example: [1], [2], [3]). As for logo variations, this project tries to use the most commonly used form or base form used by all variations. |
This is created from scratch in Inkscape, working from the 512x512px .png version. I've attempted to minimize the diff with that when this SVG is exported to .png at that resolution.