ucm2: sof-essx8336: don't use disdevall for this device #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disdevall causes undesired side effects on this device, as it breaks main microphone's detection, and makes hdmi outputs invisible at pavucontrol (tested with pipewire-pulse). So, rely on cset to disable what's not needed at the enable sequence. Fixes: 15a1250 ("ucm2: put disdevall to HDA/Soundwire configs") Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
|
I think that the problem may be somewhere else. When I track the commands in the DisableSequence for devices: The headset sequence looks suspicious and 'Speaker Switch' initialization is not in the verb's Enable sequence. For HDMI - those switches should not affect the PCM device accessibility. Could you gather any logs from wireplumber to see more details, why those devices are not detected ? |
|
Is there a way to enable internal microphone? Speaker works, but micro is not, unfortunately :( |
|
May be fixed with PR #328 . Closing, reopen if the issue persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disdevall causes undesired side effects on this device, as it breaks main microphone's detection, and makes hdmi outputs invisible at pavucontrol (tested with pipewire-pulse).
So, rely on cset to disable what's not needed at the enable sequence.
Fixes: 15a1250 ("ucm2: put disdevall to HDA/Soundwire configs")
Signed-off-by: Mauro Carvalho Chehab mchehab@kernel.org