Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucm2: Sync Librem 5 config with Purism's downstream one #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Newbytee
Copy link

@Newbytee Newbytee commented Sep 5, 2023

The config currently in this repo has several issues. The Purism
downstream one resolves these.

Taken from https://source.puri.sm/Librem5/librem5-base, commit f5b51beb144f76ef3bc483b74e19867bd6364d32

The config currently in this repo has several issues. The Purism
downstream one resolves these.

Taken from https://source.puri.sm/Librem5/librem5-base
Commit f5b51beb144f76ef3bc483b74e19867bd6364d32
@craftyguy
Copy link
Contributor

cc @agx

@perexg
Copy link
Member

perexg commented Sep 5, 2023

From the first look this is very unclean update.

Some modifications are straight, but the big ones seems a bit step back.

Some comments:

Header to Header1 is not finished (not all ConflictingDevices blocks were modified)
The disdevall "" in EnableSequence will call DisableSequences for all devices, so it's not required to duplicate the work.
Empty DisableSequence block in Verb.

@agx
Copy link
Contributor

agx commented Sep 5, 2023

@Newbytee Purism's downstream config still relies on unmerged kernel patches for the jack mic detection so it's not upstreamable as is.

/cc @dos1 as in my recollection he wanted to upstream the kernel bits before updating UCM.

@perexg perexg force-pushed the master branch 2 times, most recently from c4285c8 to b68aa52 Compare October 30, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants